summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2010-08-17 18:46:33 -0400
committerJ. Bruce Fields <bfields@redhat.com>2010-08-26 13:20:51 -0400
commit30c0e1ef0a8a6cab4e0f9357698c81a2f7f73cc5 (patch)
tree3bccc5ba7e8dff301f8dd4536158306d9261244d
parent998db52c03cd293d16a457f1b396cea932244147 (diff)
nfsd4: bad BUG() in preprocess_stateid_op
It's OK for this function to return without setting filp--we do it in the special-stateid case. And there's a legitimate case where we can hit this, since we do permit reads on write-only stateid's. Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/nfsd/nfs4state.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 0a024917f052..b990eadb799c 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2983,7 +2983,6 @@ nfs4_preprocess_stateid_op(struct nfsd4_compound_state *cstate,
*filpp = find_readable_file(stp->st_file);
else
*filpp = find_writeable_file(stp->st_file);
- BUG_ON(!*filpp); /* assured by check_openmode */
}
}
status = nfs_ok;