diff options
author | Dhaval Patel <pdhaval@codeaurora.org> | 2015-02-24 11:51:22 -0800 |
---|---|---|
committer | David Keitel <dkeitel@codeaurora.org> | 2016-03-23 20:38:12 -0700 |
commit | 9ae30a266cb1bcefb1a17125efd609502000fc37 (patch) | |
tree | 6f49aea71fe4b610866da317855a4579a484cbce | |
parent | a3eab01e8db60fa87f939a915065a79b0fa730a6 (diff) |
mdss: mdp: fix invalid error check in rotator module
Invalid input/output format error checks in rotator module
is causing rotation request failure or wrong error message
print. This change fixes such invalid checks in rotator
module.
Change-Id: I0f5f19b65c6017dd16deaa09715d29335e551b01
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
-rw-r--r-- | drivers/video/fbdev/msm/mdss_rotator.c | 20 |
1 files changed, 6 insertions, 14 deletions
diff --git a/drivers/video/fbdev/msm/mdss_rotator.c b/drivers/video/fbdev/msm/mdss_rotator.c index 0db2df9bfefa..b36ed2409682 100644 --- a/drivers/video/fbdev/msm/mdss_rotator.c +++ b/drivers/video/fbdev/msm/mdss_rotator.c @@ -258,8 +258,9 @@ static int mdss_rotator_validate_data(struct mdss_rot_mgr *mgr, } fmt = mdss_mdp_get_format_params(input->format); - if (fmt) { - pr_err("invalid input format\n"); + if (!fmt) { + pr_err("invalid input format:%d\n", input->format); + ret = -EINVAL; goto validate_data_err; } @@ -277,8 +278,9 @@ static int mdss_rotator_validate_data(struct mdss_rot_mgr *mgr, } fmt = mdss_mdp_get_format_params(output->format); - if (fmt) { - pr_err("invalid output format\n"); + if (!fmt) { + pr_err("invalid output format:%d\n", output->format); + ret = -EINVAL; goto validate_data_err; } @@ -716,16 +718,6 @@ static u32 mdss_rotator_get_out_format(u32 in_format, bool rot90) u32 format; switch (in_format) { - case MDP_RGB_565: - case MDP_BGR_565: - if (rot90) - format = MDP_RGB_888; - else - format = in_format; - break; - case MDP_RGBA_8888: - format = in_format; - break; case MDP_Y_CBCR_H2V2_VENUS: case MDP_Y_CBCR_H2V2: if (rot90) |