summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2016-03-29 18:48:07 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-12-25 14:22:16 +0100
commitd126c47656da7ca0c7921eea931e871642c90fb7 (patch)
tree076ec992e41c4894f3324c34672c6de342b1b205
parent3b67b56ea7703b6c5253c42d036e2aaae7aede73 (diff)
ALSA: hda - Fix yet another i915 pointer leftover in error path
commit 97cc2ed27e5a168cf423f67c3bc7c6cc41d12f82 upstream. The hdac_acomp object in hdac_i915.c is left as assigned even after binding with i915 actually fails, and this leads to the WARN_ON() at the next load of the module. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736 Signed-off-by: Takashi Iwai <tiwai@suse.de> Cc: Kouta Okamoto <kouta.okamoto@toshiba.co.jp> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--sound/hda/hdac_i915.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index a90322a71f86..cce9ae5ec93b 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -240,6 +240,7 @@ out_master_del:
out_err:
kfree(acomp);
bus->audio_component = NULL;
+ hdac_acomp = NULL;
dev_info(dev, "failed to add i915 component master (%d)\n", ret);
return ret;