summaryrefslogtreecommitdiff
path: root/arch/powerpc/xmon
diff options
context:
space:
mode:
authorChristophe Jaillet <christophe.jaillet@wanadoo.fr>2015-10-16 23:38:45 +0200
committerMichael Ellerman <mpe@ellerman.id.au>2015-10-21 15:31:25 +1100
commit1856f50c66dff0afb4a6a3e22497ae153aec9411 (patch)
tree3fbe657a84011f1ae98bf9f8dda8a61162ff7ffb /arch/powerpc/xmon
parentbed08b7e1fa41eac214acb17b7aa20a0e5c4b4e6 (diff)
powerpc/prom: Avoid reference to potentially freed memory
of_get_property() is used inside the loop, but then the reference to the node is dropped before dereferencing the prop pointer, which could by then point to junk if the node has been freed. Instead use of_property_read_u32() to actually read the property value before dropping the reference. of_property_read_u32() requires at least one cell (u32) to be present, which is stricter than the old logic which would happily dereference a property of any size. However we believe all device trees in the wild have at least one cell. Skiboot may produce memory nodes with more than one cell, but that is OK, of_property_read_u32() will return the first one. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> [mpe: Expand change log with device tree details] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/xmon')
0 files changed, 0 insertions, 0 deletions