summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorDaniel Drake <dsd@laptop.org>2013-06-14 15:24:24 -0400
committerJohn W. Linville <linville@tuxdriver.com>2013-06-17 14:38:51 -0400
commit6390d88529835a8ad3563fe01a5da89fa52d6db2 (patch)
tree0761f683f4a31ff7cdba5c1e1ed9cfd9d1422e4e /arch
parent3c68ef5b2223e084402a4fedbd4c31774f012f4f (diff)
mwifiex: fix memory corruption when unsetting multicast list
When trying to unset a previously-set multicast list (i.e. the new list has 0 entries), mwifiex_set_multicast_list() was calling down to mwifiex_request_set_multicast_list() while leaving mcast_list.num_multicast_addr as an uninitialized value. We were arriving at mwifiex_cmd_mac_multicast_adr() which would then proceed to do an often huge memcpy of mcast_list.num_multicast_addr*ETH_ALEN bytes, causing memory corruption and hard to debug crashes. Fix this by setting mcast_list.num_multicast_addr to 0 when no multicast list is provided. Similarly, fix up the logic in mwifiex_request_set_multicast_list() to unset the multicast list that was previously sent to the hardware in such cases. Signed-off-by: Daniel Drake <dsd@laptop.org> Acked-by: Bing Zhao <bzhao@marvell.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions