diff options
author | Eric Sandeen <sandeen@redhat.com> | 2009-03-14 11:51:46 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2009-03-14 11:51:46 -0400 |
commit | 8d03c7a0c550e7ab24cadcef5e66656bfadec8b9 (patch) | |
tree | 1fce7a08eb712e9b895ca39786e6f5bef1e632f7 /drivers/char/nvram.c | |
parent | 2842c3b5449f31470b61db716f1926b594fb6156 (diff) |
ext4: fix bogus BUG_ONs in in mballoc code
Thiemo Nagel reported that:
# dd if=/dev/zero of=image.ext4 bs=1M count=2
# mkfs.ext4 -v -F -b 1024 -m 0 -g 512 -G 4 -I 128 -N 1 \
-O large_file,dir_index,flex_bg,extent,sparse_super image.ext4
# mount -o loop image.ext4 mnt/
# dd if=/dev/zero of=mnt/file
oopsed, with a BUG_ON in ext4_mb_normalize_request because
size == EXT4_BLOCKS_PER_GROUP
It appears to me (esp. after talking to Andreas) that the BUG_ON
is bogus; a request of exactly EXT4_BLOCKS_PER_GROUP should
be allowed, though larger sizes do indicate a problem.
Fix that an another (apparently rare) codepath with a similar check.
Reported-by: Thiemo Nagel <thiemo.nagel@ph.tum.de>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'drivers/char/nvram.c')
0 files changed, 0 insertions, 0 deletions