diff options
| author | Shantanu Jain <shjain@codeaurora.org> | 2013-10-03 14:28:37 +0530 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2016-09-13 01:47:03 -0700 |
| commit | 4e02797d45d304818f0f5b0b4e5b72f2d5d08a19 (patch) | |
| tree | c8187e7b28bbecc420f73e35ef2accac018a9248 /drivers/input | |
| parent | 431c5aa98af520cfaa8dfe97b20bfe86aef8f54e (diff) | |
input: touchscreen: Correct return value check in Goodix driver
Correct return value check of gtp_read_fw_version, called in probe
of the Goodix driver. The return value is actually the number of
registers read through gtp_i2c_read() function call.
Also change the error message of gtp_check_product_id.
Change-Id: I0b643e250a487f08a19555237802b020b0873d1a
Signed-off-by: Shantanu Jain <shjain@codeaurora.org>
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/touchscreen/gt9xx/gt9xx.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/input/touchscreen/gt9xx/gt9xx.c b/drivers/input/touchscreen/gt9xx/gt9xx.c index 76250b87204d..4d71d474c113 100644 --- a/drivers/input/touchscreen/gt9xx/gt9xx.c +++ b/drivers/input/touchscreen/gt9xx/gt9xx.c @@ -1057,7 +1057,7 @@ static int gtp_check_product_id(struct i2c_client *client) ret = gtp_i2c_read(client, buf, sizeof(buf)); if (ret < 0) { - dev_err(&client->dev, "GTP read version failed.\n"); + dev_err(&client->dev, "GTP read product_id failed.\n"); return -EIO; } @@ -1740,7 +1740,7 @@ static int goodix_ts_probe(struct i2c_client *client, dev_info(&client->dev, "GTP works in interrupt mode.\n"); ret = gtp_read_fw_version(client, &version_info); - if (ret != 0) + if (ret != 2) dev_err(&client->dev, "GTP firmware version read failed.\n"); ret = gtp_check_product_id(client); |