diff options
| author | Ani Sinha <ani@arista.com> | 2015-12-17 17:15:10 -0800 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2016-09-24 03:43:50 -0700 |
| commit | ba57435ee45ab5f186ef5af6372ec0de0a7b20b1 (patch) | |
| tree | 4b491072e85a8937497641d10fa4c6fe86880519 /drivers/mfd/cros_ec.c | |
| parent | fa7978ca56d762e604e54dcad511cf57c8a5350d (diff) | |
sysrq: Fix warning in sysrq generated crash.
Commit 984d74a72076a1 ("sysrq: rcu-ify __handle_sysrq") replaced
spin_lock_irqsave() calls with rcu_read_lock() calls in sysrq. Since
rcu_read_lock() does not disable preemption, faulthandler_disabled() in
__do_page_fault() in x86/fault.c returns false. When the code later calls
might_sleep() in the pagefault handler, we get the following warning:
BUG: sleeping function called from invalid context at ../arch/x86/mm/fault.c:1187
in_atomic(): 0, irqs_disabled(): 0, pid: 4706, name: bash
Preemption disabled at:[<ffffffff81484339>] printk+0x48/0x4a
To fix this, we release the RCU read lock before we crash.
Tested this patch on linux 3.18 by booting off one of our boards.
Fixes: 984d74a72076a1 ("sysrq: rcu-ify __handle_sysrq")
Change-Id: I1827413e7e4fede197b3ebb6216239c07ae33a71
Signed-off-by: Ani Sinha <ani@arista.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Git-commit: 984cf355aeaa8f2eda3861b50d0e8d3e3f77e83b
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
Diffstat (limited to 'drivers/mfd/cros_ec.c')
0 files changed, 0 insertions, 0 deletions