diff options
author | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2018-09-26 18:11:22 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-10-13 09:11:31 +0200 |
commit | 937b51457b5fd9560a2ddb300b5dfbec87082919 (patch) | |
tree | 9201765234222ef5b2da31c6054423e171ce0399 /drivers/oprofile/oprof.h | |
parent | c6f1725b9cbd208c469142ebfc5bff476352cc08 (diff) |
fbdev/omapfb: fix omapfb_memory_read infoleak
commit 1bafcbf59fed92af58955024452f45430d3898c5 upstream.
OMAPFB_MEMORY_READ ioctl reads pixels from the LCD's memory and copies
them to a userspace buffer. The code has two issues:
- The user provided width and height could be large enough to overflow
the calculations
- The copy_to_user() can copy uninitialized memory to the userspace,
which might contain sensitive kernel information.
Fix these by limiting the width & height parameters, and only copying
the amount of data that we actually received from the LCD.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reported-by: Jann Horn <jannh@google.com>
Cc: stable@vger.kernel.org
Cc: security@kernel.org
Cc: Will Deacon <will.deacon@arm.com>
Cc: Jann Horn <jannh@google.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/oprofile/oprof.h')
0 files changed, 0 insertions, 0 deletions