diff options
| author | Shadab Naseem <snaseem@codeaurora.org> | 2019-03-25 21:52:00 +0530 |
|---|---|---|
| committer | Michael Bestas <mkbestas@lineageos.org> | 2020-02-02 01:41:02 +0200 |
| commit | 722c2dfad791dfca2b0517b32930be75b69a6581 (patch) | |
| tree | 4a9f9409f2c3e813a1184062c23c5833ddb5e6e8 /drivers/soc | |
| parent | d7a4549deb678d69097f970d1382edbbc94caf10 (diff) | |
sysmon-qmi: Fix compilation error while using LLVM
LLVM compiler gave compilation error for directly
dereferencing completion datatype for conditional check.
"warning: address of 'data->ind_recv.done' will always
evaluate to 'true' [-Wpointer-bool-conversion]"
Use completion API to fix it.
Change-Id: I985212802fe37d4b0ebe1b45e90f52d6213864f7
Signed-off-by: Shadab Naseem <snaseem@codeaurora.org>
Link: https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=e4aa68bc79aaa21ed7b1cf93daf7f2268c7f7ad4
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Diffstat (limited to 'drivers/soc')
| -rw-r--r-- | drivers/soc/qcom/sysmon-qmi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soc/qcom/sysmon-qmi.c b/drivers/soc/qcom/sysmon-qmi.c index 1063b96d8d83..aaeac1756e7a 100644 --- a/drivers/soc/qcom/sysmon-qmi.c +++ b/drivers/soc/qcom/sysmon-qmi.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014-2015, 2017, The Linux Foundation. All rights reserved. + * Copyright (c) 2014-2015, 2017, 2019, The Linux Foundation. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 and @@ -474,7 +474,7 @@ int sysmon_send_shutdown(struct subsys_desc *dest_desc) shutdown_ack_ret = wait_for_shutdown_ack(dest_desc); if (shutdown_ack_ret < 0) { pr_err("shutdown_ack SMP2P bit for %s not set\n", data->name); - if (!&data->ind_recv.done) { + if (!completion_done(&data->ind_recv)) { pr_err("QMI shutdown indication not received\n"); ret = shutdown_ack_ret; } |