diff options
author | Brian Foster <bfoster@redhat.com> | 2013-02-11 10:08:21 -0500 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-02-14 17:23:42 -0600 |
commit | 5337fe9b108d602c483fe9d62ffef9227acf3a74 (patch) | |
tree | 3f0a022ab4dbd7e60fd0f98778e6602c313d453b /fs/qnx4/bitmap.c | |
parent | a1e16c26660b301cc8423185924cf1b0b16ea92b (diff) |
xfs: recheck buffer pinned status after push trylock failure
The buffer pinned check and trylock sequence in xfs_buf_item_push()
can race with an active transaction on marking the buffer pinned.
This can result in the buffer becoming pinned and stale after the
initial check and the trylock failure, but before the check in
xfs_buf_trylock() that issues a log force. If the log force is
issued from this context, a spinlock recursion occurs on xa_lock.
Prepare xfs_buf_item_push() to handle the race by detecting a
pinned buffer after the trylock failure so xfsaild issues a log
force from a safe context. This, along with various previous fixes,
renders the log force in xfs_buf_trylock() redundant.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/qnx4/bitmap.c')
0 files changed, 0 insertions, 0 deletions