diff options
author | Julia Lawall <julia.lawall@lip6.fr> | 2016-06-01 10:28:49 -0700 |
---|---|---|
committer | Daniel Rosenberg <drosen@google.com> | 2016-07-11 19:32:16 +0000 |
commit | 96f61ff98aab275e0ac7dae4a42d3357e3d6e4a2 (patch) | |
tree | 0aae1333328d067b9259d7cfdc54781f4a0bfbb5 /fs/sdcardfs/derived_perm.c | |
parent | 6b72c6ef4442d1e4cbae32839ee69a1b42704d86 (diff) |
ANDROID: sdcardfs: fix itnull.cocci warnings
List_for_each_entry has the property that the first argument is always
bound to a real list element, never NULL, so testing dentry is not needed.
Generated by: scripts/coccinelle/iterators/itnull.cocci
Cc: Daniel Rosenberg <drosen@google.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Diffstat (limited to 'fs/sdcardfs/derived_perm.c')
-rw-r--r-- | fs/sdcardfs/derived_perm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/sdcardfs/derived_perm.c b/fs/sdcardfs/derived_perm.c index 128b3e56851f..41e0e11b3c35 100644 --- a/fs/sdcardfs/derived_perm.c +++ b/fs/sdcardfs/derived_perm.c @@ -112,7 +112,7 @@ void get_derived_permission(struct dentry *parent, struct dentry *dentry) void get_derive_permissions_recursive(struct dentry *parent) { struct dentry *dentry; list_for_each_entry(dentry, &parent->d_subdirs, d_child) { - if (dentry && dentry->d_inode) { + if (dentry->d_inode) { mutex_lock(&dentry->d_inode->i_mutex); get_derived_permission(parent, dentry); fix_derived_permission(dentry->d_inode); |