diff options
| author | Jann Horn <jannh@google.com> | 2016-06-01 11:55:07 +0200 |
|---|---|---|
| committer | Dennis Cagle <d-cagle@codeaurora.org> | 2016-09-14 11:53:53 -0700 |
| commit | b1d48a8a3cd062895b21af5972e291737ede9861 (patch) | |
| tree | 46cf41fab5c1094c0bcbf61dc53833b019671f2d /kernel/sched | |
| parent | e97b6a0e0217f7c072fdad6c50673cd7a64348e1 (diff) | |
sched: panic on corrupted stack end
Until now, hitting this BUG_ON caused a recursive oops (because oops
handling involves do_exit(), which calls into the scheduler, which in
turn raises an oops), which caused stuff below the stack to be
overwritten until a panic happened (e.g. via an oops in interrupt
context, caused by the overwritten CPU index in the thread_info).
Just panic directly.
Change-Id: I73409be3e4cfba82bae36a487227eb5260cd6e37
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Git-repo: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git
Git-commit: 29d6455178a09e1dc340380c582b13356227e8df
Signed-off-by: Dennis Cagle <d-cagle@codeaurora.org>
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 25afcb8a1402..8a5ccf334b70 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6446,7 +6446,8 @@ static noinline void __schedule_bug(struct task_struct *prev) static inline void schedule_debug(struct task_struct *prev) { #ifdef CONFIG_SCHED_STACK_END_CHECK - BUG_ON(task_stack_end_corrupted(prev)); + if (task_stack_end_corrupted(prev)) + panic("corrupted stack end detected inside scheduler\n"); #endif if (unlikely(in_atomic_preempt_off())) { |