diff options
author | Ivan Vecera <ivecera@redhat.com> | 2018-01-19 09:18:54 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-02-16 20:09:42 +0100 |
commit | f1db1b8055e6ef6e5bf94699c32fc001ce7ba063 (patch) | |
tree | f156ff05f1e461a0f8377323d600fd1b2d66aca2 /lib/debug_info.c | |
parent | fb8b16859a50f0d1fbf3e97e6ee1a82c23422b60 (diff) |
kernfs: fix regression in kernfs_fop_write caused by wrong type
commit ba87977a49913129962af8ac35b0e13e0fa4382d upstream.
Commit b7ce40cff0b9 ("kernfs: cache atomic_write_len in
kernfs_open_file") changes type of local variable 'len' from ssize_t
to size_t. This change caused that the *ppos value is updated also
when the previous write callback failed.
Mentioned snippet:
...
len = ops->write(...); <- return value can be negative
...
if (len > 0) <- true here in this case
*ppos += len;
...
Fixes: b7ce40cff0b9 ("kernfs: cache atomic_write_len in kernfs_open_file")
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/debug_info.c')
0 files changed, 0 insertions, 0 deletions