summaryrefslogtreecommitdiff
path: root/net/llc
diff options
context:
space:
mode:
authorCong Wang <xiyou.wangcong@gmail.com>2018-09-11 11:42:06 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-11-25 15:53:57 +0100
commitdb70320a71fbd38a560335a47613ac33d61eb5a7 (patch)
tree649b26c556aba19b39c04656d787f34ab3d8fd40 /net/llc
parent7c235b44dc99b4237fc0a54301eda60acc7a0af6 (diff)
llc: avoid blocking in llc_sap_close()
[ Upstream commit 9708d2b5b7c648e8e0a40d11e8cea12f6277f33c ] llc_sap_close() is called by llc_sap_put() which could be called in BH context in llc_rcv(). We can't block in BH. There is no reason to block it here, kfree_rcu() should be sufficient. Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/llc')
-rw-r--r--net/llc/llc_core.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/llc/llc_core.c b/net/llc/llc_core.c
index e896a2c53b12..f1e442a39db8 100644
--- a/net/llc/llc_core.c
+++ b/net/llc/llc_core.c
@@ -127,9 +127,7 @@ void llc_sap_close(struct llc_sap *sap)
list_del_rcu(&sap->node);
spin_unlock_bh(&llc_sap_list_lock);
- synchronize_rcu();
-
- kfree(sap);
+ kfree_rcu(sap, rcu);
}
static struct packet_type llc_packet_type __read_mostly = {