diff options
| author | Takashi Iwai <tiwai@suse.de> | 2013-11-05 15:00:02 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2013-11-06 08:34:49 +0100 |
| commit | 29fa9578046ea51e9cf97c4e16207ea6ec375084 (patch) | |
| tree | 6ce93d0fbc2653b560dc6423d2f0131f6dc0f29a /sound/pci/ctxfi/cthardware.c | |
| parent | 791b3f596e2331f80244cc8532a25b48d45f126d (diff) | |
ALSA: ctxfi: Use WARN_ON() instead of BUG_ON()
BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/ctxfi/cthardware.c')
| -rw-r--r-- | sound/pci/ctxfi/cthardware.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sound/pci/ctxfi/cthardware.c b/sound/pci/ctxfi/cthardware.c index 110b8ace6d8a..a689f2552706 100644 --- a/sound/pci/ctxfi/cthardware.c +++ b/sound/pci/ctxfi/cthardware.c @@ -69,7 +69,8 @@ unsigned int get_field(unsigned int data, unsigned int field) { int i; - BUG_ON(!field); + if (WARN_ON(!field)) + return 0; /* @field should always be greater than 0 */ for (i = 0; !(field & (1 << i)); ) i++; @@ -81,7 +82,8 @@ void set_field(unsigned int *data, unsigned int field, unsigned int value) { int i; - BUG_ON(!field); + if (WARN_ON(!field)) + return; /* @field should always be greater than 0 */ for (i = 0; !(field & (1 << i)); ) i++; |