From 252d88c7c4c8238661f99e3f17c47e3550aa5ed8 Mon Sep 17 00:00:00 2001 From: attack11 Date: Wed, 22 May 2019 16:15:58 -0300 Subject: fs: cifs: Remove unnecessary null check Clang warns: ../fs/cifs/connect.c:3090:15: error: address of array 'server->server_RFC1001_name' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] if (server->server_RFC1001_name && ~~~~~~~~^~~~~~~~~~~~~~~~~~~ ~~ 1 error generated. --- fs/cifs/connect.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index cda22b312a4c..92b19f7540d2 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -3116,8 +3116,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server) if (ses_init_buf) { ses_init_buf->trailer.session_req.called_len = 32; - if (server->server_RFC1001_name && - server->server_RFC1001_name[0] != 0) + if (server->server_RFC1001_name[0] != 0) rfc1002mangle(ses_init_buf->trailer. session_req.called_name, server->server_RFC1001_name, -- cgit v1.2.3