From 40bec6699af7f7bf33a9fd0aee419ee4b2840aa3 Mon Sep 17 00:00:00 2001 From: Gregory Bean Date: Thu, 17 Mar 2011 14:18:20 -0700 Subject: checkpatch: forbid filesystem accesses from within the kernel. Use of the sys_open/close/read/write system calls from within kernel code is inappropriate, and now triggers errors. Change-Id: I98e20513c257d0664684b7144585853f617d771a Signed-off-by: Gregory Bean (cherry picked from commit ee62f2afcac1bcb180b2f0dddf2c8f5cda54bc5b) Signed-off-by: Stepan Moskovchenko [abhimany: resolve trivial merge conflicts] Signed-off-by: Abhimanyu Kapur --- scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7057ee01178b..8f972e746990 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4894,6 +4894,13 @@ sub process { "Avoid line continuations in quoted strings\n" . $herecurr); } +# sys_open/read/write/close are not allowed in the kernel + if ($line =~ /\b(sys_(?:open|read|write|close))\b/) { + ERROR("FILE_OPS", + "$1 is inappropriate in kernel code.\n" . + $herecurr); + } + # warn about #if 0 if ($line =~ /^.\s*\#\s*if\s+0\b/) { WARN("IF_0", -- cgit v1.2.3