From 58852d2945d773a5d0f6d20329ed3d4d40f75eb6 Mon Sep 17 00:00:00 2001 From: Manoj Prabhu B Date: Wed, 1 Feb 2017 15:09:13 +0530 Subject: diag: dci: Check for valid dci client entry This patch adds the check for dci client entry validity before being accessed for its structure member. CRs-Fixed: 1097921 Change-Id: I30307599a86fff5174da1022361294e83ed8b761 Signed-off-by: Manoj Prabhu B --- drivers/char/diag/diag_dci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'drivers') diff --git a/drivers/char/diag/diag_dci.c b/drivers/char/diag/diag_dci.c index f47b390375c4..2c7662a24cd1 100644 --- a/drivers/char/diag/diag_dci.c +++ b/drivers/char/diag/diag_dci.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2012-2016, The Linux Foundation. All rights reserved. +/* Copyright (c) 2012-2017, The Linux Foundation. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 and @@ -2203,8 +2203,9 @@ struct diag_dci_client_tbl *dci_lookup_client_entry_pid(int tgid) struct diag_dci_client_tbl *entry = NULL; list_for_each_safe(start, temp, &driver->dci_client_list) { entry = list_entry(start, struct diag_dci_client_tbl, track); - if (entry->client->tgid == tgid) - return entry; + if (entry->client && entry->tgid == entry->client->tgid) + if (entry->client->tgid == tgid) + return entry; } return NULL; } -- cgit v1.2.3